Added support for previewing image in Livebook with Kino #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tab is specified in tab_order
josevalim
reviewed
Nov 6, 2022
Co-authored-by: José Valim <jose.valim@gmail.com>
josevalim
reviewed
Nov 6, 2022
josevalim
reviewed
Nov 6, 2022
josevalim
reviewed
Nov 6, 2022
josevalim
reviewed
Nov 8, 2022
josevalim
reviewed
Nov 8, 2022
Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
|
Hi @josevalim @jonatanklosko, thank you very much for the code review and suggestions😊. Sorry that I’m outside at the moment. I’ll review and update the code when I get home :) (if the PR is not merged by then |
`image.shape` is always `{h, w ,c}`
josevalim
reviewed
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
Kinois available, then defaults to theImagetab.If
KinoandNxare both available, then there will be a thirdNumericalTab.If
KinoandNxare not available, the output is the same as previous versions.It's also possible to set the order of these tabs.
When the user set
[:image, :raw, :numerical]while:nxis not available, the following message will be displayed to prompt the user to add:nxto the dependency list.And users can limit the maximum size for this feature. If either the height or width of the image exceeds that limit, the
Imagetab will not be shown.