Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for previewing image in Livebook with Kino #25

Merged
merged 12 commits into from
Nov 8, 2022
Merged

Added support for previewing image in Livebook with Kino #25

merged 12 commits into from
Nov 8, 2022

Commits on Nov 6, 2022

  1. added support for previewing image in Livebook with Kino

    @cocoa-xu
    cocoa-xu committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    16e7264 View commit details
    Browse the repository at this point in the history

  2. added support for previewing image in Livebook with Kino

    @cocoa-xu
    cocoa-xu committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    f8712cf View commit details
    Browse the repository at this point in the history

  3. fix a copy-paste mistake: set_kino_render_tab_order => kino_render_ta… 

    …b_order
    @cocoa-xu
    cocoa-xu committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    3c7f91b View commit details
    Browse the repository at this point in the history

  4. optionally define kino_render related functions

    @cocoa-xu
    cocoa-xu committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    95e8234 View commit details
    Browse the repository at this point in the history

  5. mix format

    @cocoa-xu
    cocoa-xu committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    71dc9f2 View commit details
    Browse the repository at this point in the history

  6. updated the prompt message when :nx is not available but :numerical… 

    … tab is specified in tab_order
    @cocoa-xu
    cocoa-xu committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    6c947c0 View commit details
    Browse the repository at this point in the history

  7. Update lib/stb_image.ex 

    Co-authored-by: José Valim <jose.valim@gmail.com>
    @cocoa-xu @josevalim
    cocoa-xu and josevalim committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    851a49c View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. using Application.fetch_env!/2

    @cocoa-xu
    cocoa-xu committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    020332e View commit details
    Browse the repository at this point in the history

  2. remove require Logger

    @cocoa-xu
    cocoa-xu committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    cb47754 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Apply suggestions from code review

    @josevalim
    josevalim committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    acf4682 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
    @josevalim @jonatanklosko
    josevalim and jonatanklosko committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    706b518 View commit details
    Browse the repository at this point in the history

  3. Remove redundant matching 

    `image.shape` is always `{h, w ,c}`
    @cocoa-xu
    cocoa-xu committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    5f55c46 View commit details
    Browse the repository at this point in the history