Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use idiomatic naming for Dockerfiles #47

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

lexmag
Copy link
Contributor

@lexmag lexmag commented Aug 5, 2023

The advisable pattern of naming Dockerfiles is [<app/context>.]Dockerfile.
There is also as special case: <app/context>.Dockerfile.dockerignore (see https://docs.docker.com/engine/reference/commandline/build/#use-a-dockerignore-file).

Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks :)

@jonatanklosko jonatanklosko merged commit c2b4a23 into elixir-nx:main Aug 6, 2023
@lexmag lexmag deleted the df-rename branch December 12, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants