Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve callback documentation #1013

Merged
merged 2 commits into from
Feb 16, 2021
Merged

Conversation

sabiwara
Copy link
Contributor

Hi! This is a small PR to improve the documentation for callbacks:

  • Fixed references to callbacks
  • Named callback arguments for clearer signatures (e.g. get(conn, cookie, opts) instead of get(arg1, cookie, arg3))

Before

Screenshot from 2021-02-16 15-07-19

After

Screenshot from 2021-02-16 15-06-54

@josevalim josevalim merged commit 64d9436 into elixir-plug:master Feb 16, 2021
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants