add index option to static plug #527
Conversation
|
Hello, @jackxxu! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/elixir-lang/plug/pulls/527. |
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
| when meth in @allowed_methods do | ||
| segments = subset(at, conn.path_info) | ||
| |> index_on_root(index) |
There was a problem hiding this comment.
Use a function call when a pipeline is only one function long
|
Hi @jackxxu. We don't plan to support index lookup on static. If that is something you find necessary, you can write a plug that matches on the static prefix and rewrites the URLs accordingly. Thank you. |
Many times, when we need to make a directory of static content available via a http server, it is beneficial to configure a "default" content to be rendered when the root url is requested.
Similar configuration exists in other similar frameworks, such as Rack.