include crash_reason in translator

[mitchellhenke]

I wasn't sure on the odds of this being accepted, as I haven't seen including the error_reason key outside of core, and it does have some special considerations: https://github.com/elixir-lang/elixir/blob/master/lib/logger/lib/logger/backends/console.ex#L195

The goal is to be able to access more structured error information through Logger, similar to elixir-lang/elixir#7841

[josevalim]

We would love to accept this but unfortunately it requires recent Elixir version. Maybe we should check the Elixir version before returning it?

[mitchellhenke]

ohhhhh, yeah. is checking at runtime fine?

[josevalim]

I think we can do this:

if Version.match?(System.version(), "~> 1.6") do
  defp ok(message, metadata) do
    {:ok, message, metadata}
  end
else
  defp ok(message, _metadata) do
    {:ok, message}
  end
end

And then we do:

ok(
  [
    inspect(pid),
    " running ",
    inspect(mod),
    extra,
    " terminated\n",
    conn_info(min_level, conn)
    | Exception.format(:exit, reason, [])
 ],
 [crash_reason: reason]
)

The advantage is then that we won't have to rewrite whole functions.

[mitchellhenke]

things got weird with github being down for a bit, but I've amended the commit for excluding metadata

[josevalim]

❤️ 💚 💙 💛 💜