Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MediaStreamTrack.t() as a parameter to send_rtp/3 #72

Merged
merged 7 commits into from
Feb 19, 2024

Conversation

srcrip
Copy link
Contributor

@srcrip srcrip commented Feb 17, 2024

hey, in my experimentation, this handle_cast for :send_rtp always receives a full track, not an id. This change makes everything work, but if you want it to be different feel free to edit my pr.

@srcrip
Copy link
Contributor Author

srcrip commented Feb 17, 2024

Actually now that I'm looking at my code closer I realized it was in fact my fault. I was sending the track explicitly.

Since that's an easy mistake to make, would it be ok if I edit this function to accept a track or track id and just handle both appropriately?

@srcrip srcrip marked this pull request as draft February 17, 2024 12:21
@srcrip srcrip changed the title :send_rtp for handle_cast receives track instead of id :send_rtp for handle_cast in peer_connection changes Feb 17, 2024
@srcrip srcrip marked this pull request as ready for review February 17, 2024 12:29
@srcrip
Copy link
Contributor Author

srcrip commented Feb 17, 2024

ok I've switched things up a bit:

  • added a @doc for send_rtp
  • made it able to accept track_id or mediastreamtrack, that way someone can mess up the way I did and it will just work

@LVala
Copy link
Member

LVala commented Feb 17, 2024

Thanks for the PR! SGTM, although the non-W3C functions in the API are quite experimental and may change in future versions, so this change might not be ever released, just keep that in mind.

We'll probably get back to it and merge on Monday.

@LVala LVala changed the title :send_rtp for handle_cast in peer_connection changes Allow MediaStreamTrack.t() as a parameter to send_rtp/3 Feb 19, 2024
@LVala LVala merged commit 73c247b into elixir-webrtc:master Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants