-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for RTCP Sender Reports #78
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 88.43% 88.60% +0.16%
==========================================
Files 29 30 +1
Lines 1306 1334 +28
==========================================
+ Hits 1155 1182 +27
- Misses 151 152 +1
Continue to review full report in Codecov by Sentry.
|
} = recorder | ||
|
||
delta = packet.sequence_number - last_seq_no | ||
in_order? = delta < -@breakpoint or (delta > 0 and delta < @breakpoint) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a comment here, sth like
A packet is in order when it is from the next cycle, or current cycle with delta > 0
In ReceiverReports we have:
cycle =
cond do
delta in -@breakpoint..@breakpoint -> last_cycle
delta < -@breakpoint -> last_cycle + 1
delta > @breakpoint -> last_cycle - 1
end
which is really nice and easy to to read but if someone didn't see this code, it might be pretty hard to get what's going on?
This PR adds
RTPSender.ReportRecorder
module, akin toRTPReceiver.ReportRecorder
andPeerConnection.TWCCRecorder
.