Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RTCP Sender Reports #78

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Add support for RTCP Sender Reports #78

merged 5 commits into from
Feb 29, 2024

Conversation

LVala
Copy link
Member

@LVala LVala commented Feb 27, 2024

This PR adds RTPSender.ReportRecorder module, akin to RTPReceiver.ReportRecorder and PeerConnection.TWCCRecorder.

@LVala LVala self-assigned this Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Merging #78 (14e791a) into master (682c434) will increase coverage by 0.16%.
Report is 1 commits behind head on master.
The diff coverage is 96.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   88.43%   88.60%   +0.16%     
==========================================
  Files          29       30       +1     
  Lines        1306     1334      +28     
==========================================
+ Hits         1155     1182      +27     
- Misses        151      152       +1     
Files Coverage Δ
lib/ex_webrtc/rtp_sender/report_recorder.ex 96.42% <96.42%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 682c434...14e791a. Read the comment docs.

@LVala LVala marked this pull request as ready for review February 27, 2024 14:49
@LVala LVala requested a review from mickel8 February 27, 2024 14:49
} = recorder

delta = packet.sequence_number - last_seq_no
in_order? = delta < -@breakpoint or (delta > 0 and delta < @breakpoint)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a comment here, sth like

A packet is in order when it is from the next cycle, or current cycle with delta > 0

In ReceiverReports we have:

    cycle =
      cond do
        delta in -@breakpoint..@breakpoint -> last_cycle
        delta < -@breakpoint -> last_cycle + 1
        delta > @breakpoint -> last_cycle - 1
      end

which is really nice and easy to to read but if someone didn't see this code, it might be pretty hard to get what's going on?

@LVala LVala merged commit 8328e84 into master Feb 29, 2024
4 checks passed
@LVala LVala deleted the rtcp-sender-reports branch February 29, 2024 14:01
@LVala LVala mentioned this pull request Feb 29, 2024
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants