Use normalized comparison in PeerConnection.Configuration.supported_codec?/2 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clone1018
commented
Mar 11, 2024
mickel8
requested changes
Mar 11, 2024
| rtpmap = ExSDP.get_attribute(mline, :rtpmap) | ||
|
|
||
| Logger.warning( | ||
| "No valid codecs for \"#{rtpmap}\" found in registered %ExWebRTC.PeerConnection.Configuration{}" |
There was a problem hiding this comment.
I think we should use inspect here, shouldn't we? rtpmap should be a struct.
Suggested change
| "No valid codecs for \"#{rtpmap}\" found in registered %ExWebRTC.PeerConnection.Configuration{}" | |
| "No valid codecs for #{inspect(rtpmap)} found in registered %ExWebRTC.PeerConnection.Configuration{}" |
There was a problem hiding this comment.
This actually prints nicely by default thanks to: https://github.com/membraneframework/ex_sdp/blob/master/lib/ex_sdp/attribute/rtp_mapping.ex#L62
Let me know if you want to keep that, or swap it out for inspect!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a couple of minor things: