Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mobile styles to nav #141

Merged
merged 1 commit into from Mar 6, 2016

Conversation

jessejanderson
Copy link
Contributor

image

@jessejanderson
Copy link
Contributor Author

Not sure the best way to do this, but it would be great if the navigation was toggled close by default on mobile.

@doomspork
Copy link
Member

I agree, the menu is getting a bit long these days. Any suggestions? One option might be to have all sections closed by default for everyone.

@doomspork
Copy link
Member

Collapsing the menu may a good solution to #96

@doomspork
Copy link
Member

@pjhampton and @pragmaticivan, what do you think about collapsing the menus by default? Right now they're a bit long, this might serve to buy us some time building a whole new site.

Thoughts?

@doomspork doomspork added the enhancement An enhancement to Elixir School content label Mar 6, 2016
@pjhampton
Copy link
Contributor

This looks swell.

All devices - Maybe it could paginated? I say this because I think it maybe a good idea to show at least the basic lessons in the menu my default, until maybe they move to another section?

Only mobile - If this just applies to mobile, then I think that is good 👍

thanks @jessejanderson

@pragmaticivan
Copy link
Member

I like the new just mobile menu, just tested here locally, but would collapse the menu and just show the basics area. And also need to detect when an advanced area is active, so it needs to show the advanced area opened instead the basic area.

@doomspork
Copy link
Member

Thanks for your thoughts @pragmaticivan and @pjhampton. I'm going to merge this as-is but I'm open to a PR to improve collapsing the menus.

Thanks again @jessejanderson this is great 👍

doomspork added a commit that referenced this pull request Mar 6, 2016
@doomspork doomspork merged commit 3ba52f5 into elixirschool:master Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to Elixir School content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants