Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the translation of word "string" in zh-hans may be "字符串" #1499

Merged

Conversation

Hanaasagi
Copy link
Contributor

No description provided.

@doomspork doomspork requested a review from a team September 11, 2018 17:48
@doomspork
Copy link
Member

Thank you @Hanaasagi! I'll give our reviewers a chance to take a peek at these changes before I merge.

@doomspork doomspork added the enhancement An enhancement to Elixir School content label Sep 11, 2018
Copy link
Member

@zillou zillou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@doomspork
Copy link
Member

Thank you @Hanaasagi and @zillou!

@zillou in the future feel free to Squash and merge when you're happy with the PR 👍

@doomspork doomspork merged commit bc18a1a into elixirschool:master Sep 13, 2018
dabielf pushed a commit to dabielf/elixirschool that referenced this pull request Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to Elixir School content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants