Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecto Changesets chapter #1563

Merged
merged 1 commit into from Nov 15, 2018
Merged

Conversation

svileng
Copy link
Contributor

@svileng svileng commented Oct 19, 2018

Changesets chapter for #1519.

I mostly followed the topics outlined in #1519 ; I decided not to have dedicated section for Changeset design approaches, but rather try to sneakily introduce this kind of thinking, alongside the other content. Not sure if it was successful, so I'd love to hear people's feedback 馃槅

Any feedback is of course welcome 馃槃

@doomspork doomspork added hacktoberfest-approved new lesson An completely new lesson (not a translation) labels Oct 21, 2018
@doomspork doomspork requested review from a team November 10, 2018 20:47
@doomspork
Copy link
Member

@svileng could you change the filename to exclude the 03_ prefix?

doomspork
doomspork previously approved these changes Nov 10, 2018
Copy link
Member

@doomspork doomspork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svileng apologizes for the delay, this lesson looks great. Could you please update the lesson filename then I can get this merged.

@svileng
Copy link
Contributor Author

svileng commented Nov 12, 2018

Changed to changesets.md 馃憤

@doomspork doomspork merged commit deeeddb into elixirschool:master Nov 15, 2018
@doomspork
Copy link
Member

Thank you @svileng! I need to make a couple configuration changes and then the change will be live on the site 馃榿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-approved new lesson An completely new lesson (not a translation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants