New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a new lesson Strings in the basics section #224
Conversation
lang: en | ||
--- | ||
|
||
String manipulation is one of our must to have skills nowadays, ignoring the programming language. That's why we are including an in-depth on Strings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String manipulation is one of our must
tohave skills nowadays~~, ignoring the programming language~~.That's why we are including an in-depth on Strings.
Most of the above doesn't fit into the typical overview of Elixir School. Consider finishing it off with something about codepoints and graphemes.
Hi @setzer777, thanks for taking the initiative on this! This is going to be great. There's a couple pieces of feedback to look through and we should be good. Two general pieces of feedback for new lessons:
|
@doomspork @pjhampton Now that I know there's a Lesson Styleguide I'll not make the same mistakes again c: haha and thanks a lot for taking the time to give me some feedback! I'll make the corrections at the end of the day c: |
No worries @setzer777, we really appreciate the help! 😀 |
@setzer777 yeah definitely man. It's your first lesson.. it's always the hardest!! 😄 |
Oh my god guys, I've been super busy D: hopefully tonight I'll correct this... So sorry 😢 |
No worries @setzer777! 😀 |
0c05865
to
15bfd78
Compare
Finally I had the time to make the corrections :) haha I think that's it guys, give it a quick check again and if it's ready, let's merge! 👍 |
"Hallo" | ||
``` | ||
|
||
##### `duplicate(string, n)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency's sake, let's use duplicate/2
here.
15bfd78
to
83eea05
Compare
@pjhampton I already made the corrections. FFS, I can't believe those last ones went out of my watch hahaha. Thanks a lot for the last review, hopefully it's the last last xD |
@@ -0,0 +1,156 @@ | |||
--- | |||
layout: page | |||
title: Strings in-depth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@setzer777 / @pjhampton — What about just "Strings" and adding this to the Basics section instead of Advanced?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! @setzer777 let's add this as the last lesson in the Basics and rename it to "Strings", then I think it's good to go 👍
83eea05
to
f440476
Compare
Is it change order of lessons, isn't it? |
Hi @setzer777, I've been traveling a lot lately. Apologizes for the delays in looking this over and merging. I will make it a priority for later this week when I am home. @Koziolek we're going to append this lesson to the end the Basic Lessons, it shouldn't require a re-ordering. |
Let's ship this. It looks good to me, except some edges which will be worked out over time. Super thank @setzer777 ~ you've done a great job! |
Thanks @setzer777 (and @pjhampton)! Sorry for the delays, been quite busy all of a sudden. I'm anxious to see how people respond to the exercises. |
@doomspork @pjhampton What do you think guys?
I didn't go full in-depth tho, but I think the content is enough to understand better Strings in Elixir 👍