Changing header metadata to show correct information with sharing. #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosangwon
added
enhancement
|
This is great @devleoper!! This is good to merge from my perspective, any additional changes you'd like to make before I do so? |
|
It's ready to be merged. I think there isn't additional thing at this time for this. 😃 |
rezaprima
added a commit
to rezaprima/elixir-school
that referenced
this pull request
Jul 20, 2016
* 'master' of https://github.com/doomspork/elixir-school: (122 commits) Renamed and applied enhancement for Korean Translation of Modules (elixirschool#518) [JP] Improve translation in metaprogramming lesson (elixirschool#458) [JP] Add description of special syntax of map (elixirschool#508) Create spanish translation for error handling page (elixirschool#389) [JP] Add error handling lesson (elixirschool#451) [NO] Translation of the sections referenced in elixirschool#480 and elixirschool#481 (elixirschool#486) [SK] Translation of the sections referenced in elixirschool#480 and elixirschool#481 (elixirschool#504) Changed meta descriptions and og:url to show proper information. (elixirschool#517) Stylesheets for Printers. (elixirschool#520) Renamed "Composition" Lessons in other languages to "Modules" Lesson (elixirschool#519) Correct the translation of "Korean" (elixirschool#516) fix typo (elixirschool#515) Remove duplicate from Russian glossary (elixirschool#514) Improved "Pipe operator" lesson according to suggestion in elixirschool#305 task (elixirschool#511) Add one more step to 'new language' process (elixirschool#512) Add more language links to main page (elixirschool#510) [KO] Translated updating/accessing maps section into Korean (elixirschool#491) [KO] Translation of OTP Supervisor lesson (elixirschool#426) [KO] Translation of Concurrency lesson (elixirschool#466) [KO] Translation of Umbrella Projects Lesson. (elixirschool#490) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
og:urlvalue to URL of each page will help showing information in Open Graph correctly. (Currently if we share any page to Facebook, we will see same previews becauseog:urlpoints only the main page.)And changed
descriptionandog:descriptionto show translated description of Elixir School.Where can we go further?
We can set
descriptions which make summary for each page to make sneak-peeking easy.