Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/default-preset-missing-from-default-settings-struct #5

Merged

Conversation

eljamo
Copy link
Owner

@eljamo eljamo commented May 21, 2024

  • fix: fix issue where preset and pad_to_length config keys weren't getting a default set in DefaultSettings()
  • refactor: refactor some code to make it easier to test bits of functionality
  • refactor: update caser pool to return a pointer and not a value
  • docs: add example/example.go
  • docs: update README.md
  • ci: update and add workflows
  • test: add DefaultSettings() test
  • test: add a bunch of tests for asset/asset.go and config/settings.go

fix: fix issue where preset config key wasn't getting a default set in efaultSettings()
test: add DefaultSettings() test
docs: add example/example.go
docs: update README.md
test: increase coverage
ci: fix test coverage command
example/example.go Dismissed Show dismissed Hide dismissed
Repository owner deleted a comment from github-advanced-security bot May 21, 2024
@eljamo eljamo merged commit 0db3fb4 into main May 21, 2024
4 checks passed
@eljamo eljamo deleted the bugfix/default-preset-missing-from-default-settings-struct branch May 21, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant