-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the sidenav responsive on height #894
Comments
Doing an experiment to start improvement (not adaptiveness yet, only reorganization) https://github.com/elk-zone/elk/tree/experiment/side-nav-prototyping |
I think we should avoid removing items from the side nav. Having to open a submenu is at least as cumbersome as having to scroll, if not more so. Rather than remove items entirely, I think it would make sense to relocate them when the screen is wide enough, move items that are not navigation (e.g., the account switcher, search box, or possibly the Elk logo) to the right side). I think the account switcher could also be made the same height as other sidebar items, with the user's handle in a smaller font size, which would have the added benefit of cutting off less of the user's server. |
We should try first to avoid removing items (reducing space and making some less tall), but there are some that are not used that much like favourites, so it does makes sense to push to the three dots to avoid the scrollbar. About moving things to the other side, I think we should wait until we see what other things end up there. It is empty only temporarly. |
@patak-dev I assumed there might be plans for that space. Is that roadmap documented somewhere? IIRC, there was a previous iteration of Elk that had the search box on the right side when space was available. |
In my case I created a userContent.css file to adapt the content of the side menu because I had a scroll bar on my laptop screen.
And in the content of the posts, the vertical margins of the paragraphs have been increased to make the empty lines stand out better. |
That makes think we could override in CSS inside the account settings to get this without extension! |
About Appréciés button name, we could revert it but we need to harmonize with other translations |
On Mastodon, it's "Favoris" (translation of "Favorites" in French) but on the other hand, it's "J'aime" on Twitter... Also, I just saw that there is "@ Direct Messages" on Mastodon which must match "@ Conversations" so I shouldn't have deleted it :) |
According to Discord thread
I have a concern about the sidenav layout and the consequence on wide (or not tall enough) screens.
See the attached image of the side nav: the account part is cropped (the viewport size is 1536x731 on my desktop)
It should never get scroll bar for UX purpose!
For making sure scroll never comes, we should add a responsiveness mechanism to hide items using usability order.
Great principales written by @patak-dev :
My opinion is agreeing previous point but I would like to extends (it's my own):
The text was updated successfully, but these errors were encountered: