-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: explore and search unified #1274
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I am not opposed to a unified experience like Twitter (and kind of Mastodon default web), but in that case, I think the search box should be at the top OR at the bottom with search suggestions above it. In the middle leaves too little room in a short window. I would strongly prefer Twitter's approach of moving the search box to the top-right and not having it in the sidebar at all in large windows, and then replacing Explore in the sidebar in medium size windows. |
One issue with this approach is that you can no longer search while looking at the context around. You are forced to go to the search route. I evaluated doing this for search instead of having the results in a dropdown but I didn't move forward for this reason. I think a search input that doesn't take you out of the current route is important to keep. |
This is a great improvement for the mobile UI, where having an empty search pane was a bit weird. I agree with patak for the desktop UI, the current UI is in my opinion better. |
Updated @patak-dev @ZMYaro @baptiste0928 |
I think we should leave Search on the left sidebar, I like that it is stable as you resize. And I don't mind it disappearing for smaller screens instead of taking height space. I would prefer to keep the current interface and review once we have more content on the right side to see how everything fits together. |
I'll do it in a separate PR |
Description
Merge usage of search and explore in one.
Use search and explore button which will redirect to the explore page but put the focus on the search field which takes same place than the search and explore just clicked.
Resolves #1258
Resolves #894
Additional context
This has been made to optimize the number of nav items without loosing any.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).