Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: explore and search unified #1274

Closed
wants to merge 9 commits into from
Closed

Conversation

edimitchel
Copy link
Collaborator

@edimitchel edimitchel commented Jan 17, 2023

Description

Merge usage of search and explore in one.
Use search and explore button which will redirect to the explore page but put the focus on the search field which takes same place than the search and explore just clicked.

Resolves #1258
Resolves #894

explore-search

Additional context

This has been made to optimize the number of nav items without loosing any.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Translations update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide related snapshots or videos.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@edimitchel edimitchel linked an issue Jan 17, 2023 that may be closed by this pull request
@stackblitz
Copy link

stackblitz bot commented Jan 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 17, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 6381bcf
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63c7dcb30eb1d00009e8a8ef

@netlify
Copy link

netlify bot commented Jan 17, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 6381bcf
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63c7dcb3dfe0810008237702
😎 Deploy Preview https://deploy-preview-1274--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ZMYaro
Copy link

ZMYaro commented Jan 18, 2023

I am not opposed to a unified experience like Twitter (and kind of Mastodon default web), but in that case, I think the search box should be at the top OR at the bottom with search suggestions above it. In the middle leaves too little room in a short window.

I would strongly prefer Twitter's approach of moving the search box to the top-right and not having it in the sidebar at all in large windows, and then replacing Explore in the sidebar in medium size windows.

@patak-dev
Copy link
Member

One issue with this approach is that you can no longer search while looking at the context around. You are forced to go to the search route. I evaluated doing this for search instead of having the results in a dropdown but I didn't move forward for this reason. I think a search input that doesn't take you out of the current route is important to keep.

@baptiste0928
Copy link
Contributor

baptiste0928 commented Jan 18, 2023

This is a great improvement for the mobile UI, where having an empty search pane was a bit weird. I agree with patak for the desktop UI, the current UI is in my opinion better.

@edimitchel
Copy link
Collaborator Author

Updated @patak-dev @ZMYaro @baptiste0928

@patak-dev
Copy link
Member

I think we should leave Search on the left sidebar, I like that it is stable as you resize. And I don't mind it disappearing for smaller screens instead of taking height space. I would prefer to keep the current interface and review once we have more content on the right side to see how everything fits together.

@edimitchel edimitchel closed this Jan 18, 2023
@baptiste0928
Copy link
Contributor

The search pane on mobile devices is actually empty, what do you think about merging search and explore but for only on mobile?

Current search pane:
search-mobile-current

With this PR:
search-mobile-new

@edimitchel
Copy link
Collaborator Author

I'll do it in a separate PR
I have also few UI optimization ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use explore page as search page Make the sidenav responsive on height
4 participants