feat: use explorer page as search for mobile only #1301
Conversation
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
As I said on #1274, I think it would make more sense to follow Twitter's example and have the Search icon replace the Explore icon in medium size windows instead of being a redundant link to the same page. |
Applied. |
|
Let's merge this one so we avoid the need to resolve conflicts and iterate. I think we'll need to review how this will look if we show search results similar to the timeline more like a dialog for mobile later. |
|
Hey just to chime in on this - I feel like there should be a setting to toggle this as desired by the user. I really like having 'explore' hidden away, as to not get in the way when just trying to do a simple search. On twitter, I understood why they might want to shove trending posts in my face, but it has been very refreshing to not have that on mastodon. I think many other people appreciate that about mastodon VS twitter as well :) Anyone else relate? |
|
I agree here, I was also hesitant about making this change but it is good that we tried to get some more data. There were a few messages from folks confused by it on Mastodon. I think we should revert and have to explore and search separately again and let people explicitly go to explore when they want to discover content (I don't use explore at all for example, so I also prefer not to see it). About having an option to merge them, I think it is better to avoid it for now as we already have too many options, and it isn't clear to me that a lot of people are asking for this. This PR introduces others changes too that are great (sticky user in the sidebar, etc), @edimitchel let me know if you'd like to send a revert only for the merging part, if not I'll get to it later today or tomorrow |
|
I can do a revert but I would like to suggest another thing: on mobile, when search is clicked only show the search input and focus to it. |
|
Yes, I think we can revert then keep exploring how to improve things. |
|
That sounds like a good plan! Either way, thanks for putting in time to explore these options @edimitchel, I appreciate it! It's useful to see features like this actually implemented, to get a better understanding of them 🙌 |
Description
Merge usage of search and explore in one only for mobile or medium screen (could have both search and explore icon active for medium screen).
Resolves #1258
Resolves #894
Resolves #1560
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).