Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: quickfixes #1603

Merged
merged 4 commits into from
Feb 3, 2023
Merged

feat: quickfixes #1603

merged 4 commits into from
Feb 3, 2023

Conversation

boehs
Copy link
Member

@boehs boehs commented Feb 3, 2023

consider merging without squashing, each fix is contained in it's own commit

@stackblitz
Copy link

stackblitz bot commented Feb 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Feb 3, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 4079055
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63dd4433cb319c0008bbba89

@netlify
Copy link

netlify bot commented Feb 3, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 4079055
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63dd443362b2140008a640c0
😎 Deploy Preview https://deploy-preview-1603--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@boehs boehs added the do NOT merge yet Do not merge this PR into the target branch yet label Feb 3, 2023
@boehs boehs changed the title quickfixes feat: quickfixes Feb 3, 2023
@patak-dev
Copy link
Member

@boehs this looks good to me, are you planing to add more commits on top of it? Even if it is a bit of extra work I would prefer we keep doing one PR per feature/fix as it is a lot easier then merging and discuss each individually 🙏🏼
We can still move on with this one though.

@boehs
Copy link
Member Author

boehs commented Feb 3, 2023

@boehs this looks good to me, are you planing to add more commits on top of it? Even if it is a bit of extra work I would prefer we keep doing one PR per feature/fix as it is a lot easier then merging and discuss each individually 🙏🏼 We can still move on with this one though.

sounds good. It kinda occurred to me as I was 3rd commit in. Sure, 3 is better than none!

@@ -400,6 +400,7 @@
"github_cards": "GitHub Cards",
"grayscale_mode": "Grayscale mode",
"hide_account_hover_card": "Hide account hover card",
"hide_alt_indi_on_posts": "Hide alt indicator on posts",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"hide_alt_indi_on_posts": "Hide alt indicator on posts",
"hide_alt_indicator_on_posts": "Hide alt indicator on posts",

?

Copy link
Member Author

@boehs boehs Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I'll package this with a future pull request if that's ok (I have a couple more I hope will be done today)

And now I really see what @patak-dev meant ;)

@boehs boehs removed the do NOT merge yet Do not merge this PR into the target branch yet label Feb 3, 2023
@patak-dev patak-dev merged commit 0258894 into elk-zone:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants