-
-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: quickfixes #1603
feat: quickfixes #1603
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@boehs this looks good to me, are you planing to add more commits on top of it? Even if it is a bit of extra work I would prefer we keep doing one PR per feature/fix as it is a lot easier then merging and discuss each individually 🙏🏼 |
sounds good. It kinda occurred to me as I was 3rd commit in. Sure, 3 is better than none! |
@@ -400,6 +400,7 @@ | |||
"github_cards": "GitHub Cards", | |||
"grayscale_mode": "Grayscale mode", | |||
"hide_account_hover_card": "Hide account hover card", | |||
"hide_alt_indi_on_posts": "Hide alt indicator on posts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"hide_alt_indi_on_posts": "Hide alt indicator on posts", | |
"hide_alt_indicator_on_posts": "Hide alt indicator on posts", |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. I'll package this with a future pull request if that's ok (I have a couple more I hope will be done today)
And now I really see what @patak-dev meant ;)
consider merging without squashing, each fix is contained in it's own commit