fix: limit pinch scale to minimum 0.5 #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
emanuelpina
pushed a commit
to emanuelpina/elk
that referenced
this pull request
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw this zoom bug and it's also mentioned here: #1620 (comment)
Before:
scaleto go negative thus flipping the image up-side-downpinch-scale-bug-before.mp4
After:
scalefrom becoming negative.pinch-scale-bug-after.mp4
Tested on Chrome v109.0.5414.119 (Official Build) (arm64) and Edge v109.0.1518.78 (Official build) (arm64) on MacOS Ventura 13.2.