Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pwa): add FAQ to PWA docs and link on push subscription error #1767

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

userquin
Copy link
Member

This PR adds always a new hint on push subscription error, the new hint will link to PWA FAQ in docs.

When merged, we should also deploy docs.

Captura de pantalla 2023-02-16 170427

@stackblitz
Copy link

stackblitz bot commented Feb 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Feb 16, 2023

Deploy Preview for elk-docs ready!

Name Link
🔨 Latest commit 58e82cd
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63eecb180b615d00080fa924
😎 Deploy Preview https://deploy-preview-1767--elk-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 16, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 58e82cd
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63eecb180935eb0008b424d5
😎 Deploy Preview https://deploy-preview-1767--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@userquin
Copy link
Member Author

This PR includes a new entry in en.json and es.json:

  • settings.notifications.push_notifications.subscription_error.error_hint

docs/content/80.pwa.md Outdated Show resolved Hide resolved
Co-authored-by: Michel EDIGHOFFER <edimitchel@gmail.com>
@patak-dev patak-dev merged commit 6f96c73 into main Feb 17, 2023
@patak-dev patak-dev deleted the userquin/feat-push-subscription-error branch February 17, 2023 11:11
emanuelpina pushed a commit to emanuelpina/elk that referenced this pull request Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants