Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle frozen state #1792

Merged
merged 1 commit into from
Feb 25, 2023
Merged

fix: handle frozen state #1792

merged 1 commit into from
Feb 25, 2023

Conversation

userquin
Copy link
Member

@userquin userquin commented Feb 18, 2023

This shoudn't fix #1791

@stackblitz
Copy link

stackblitz bot commented Feb 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Feb 18, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 55a9af5
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63f0de49ddba5000080998fd

@netlify
Copy link

netlify bot commented Feb 18, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 55a9af5
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63f0de498f5726000820d079
😎 Deploy Preview https://deploy-preview-1792--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@patak-dev
Copy link
Member

@userquin this should fix the issue you linked? Or do you mean we should merge this one, but keep the referenced issue open?

@userquin
Copy link
Member Author

userquin commented Feb 18, 2023

@patak-dev yeah sorry, the issue shouldn't be closed, it is another problem with network switching.

Before merging this I'll send a DM to @edimitchel to check the preview on FF.

@userquin
Copy link
Member Author

@patak-dev I guess this can be merged

@patak-dev patak-dev merged commit 3596d8b into main Feb 25, 2023
@patak-dev patak-dev deleted the userquin/feat-handle-frozen-state branch February 25, 2023 11:09
@johnsonm
Copy link

I see that #1791 was closed anyway. Was that automation because the bot saw "fix" next to "#1791"? If it shouldn't have been closed, can someone with project permissions re-open it? ☺

@userquin
Copy link
Member Author

I see that #1791 was closed anyway. Was that automation because the bot saw "fix" next to "#1791"? If it shouldn't have been closed, can someone with project permissions re-open it? ☺

Reopened

DataDrivenMD pushed a commit to Distal-Labs/elk that referenced this pull request Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elk does not refresh on Firefox on Android across network changes
3 participants