fix: properly parse bolded italics #1808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would appear that the current markdown replacer function for bolded italics (line 448) that converts a match into an ultrahtml
h()
object doesn't expect an array inc
's place.elk/composables/content-parse.ts
Lines 447 to 455 in 29b37e6
When supplied with c =
['foo']
, it simply puts['foo']
in the elements children, which isn't properly parsed by Vue. If instead, it is in the form'foo'
, it's parsed properly.I'm not too familiar with ultrahtml but this seems to work for me and seems to be the root cause as far as I can tell.
Before: (Screenshot taken from mocked dev, but I'd guess viewing this would yield similar results)
After:
Fixes #1804.