-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Include following count in hide follower count setting #1897
feat: Include following count in hide follower count setting #1897
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for elk-docs canceled.
|
pages/settings/preferences/index.vue
Outdated
:checked="getPreferences(userSettings, 'hideFollowingFollowerCount')" | ||
@click="togglePreferences('hideFollowingFollowerCount')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think we should leave the name of the preference as it was before though because if not, everyone will lose this preference and will need to re-enable it. We could add a backward-compatible scheme, but I think the previous name is good enough here.
@patak-dev I reversed the name of preference to Since the name of the displayed text remains unchanged and the non-English displayed texts have not yet updated in this PR. User who uses non-English interface may not notice the changes. Remember to update the language file for other language later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! Let's merge this.
But I wonder if we should also only hide the followers/following counts in hover cards and then on profile still show "Followers" / "Following" without numbers but at least let the user click on them so they can explore. Checking who a person follows is a good way to learn about new good follows, and I think it doesn't go against the health preference.
@patak-dev But I agree to keep showing "Followers" / "Following" label without numbers (in both hover cards and full profile page) so that user can click on them to see the following list and the follower list. |
Before changes: Enabling "Hide follower count" in the wellbeing setting can hide the follower count in the account profile page.
I changed that setting to "Hide following/follower count" which can hide both following count and follower count.
Close #1878