Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent the lost of focus on compose icons #2253

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Jul 22, 2023

fix #1679

This was caused by autofocusing the tooltip during keyboard navigation.

A similar issue was reported in the original floating-vue repository (Akryum/floating-vue#872), which is the component we use to implement the CommonTooltip, and the no-auto-fucus option was implemented as mitigation.

I found the same issue on the "created at" time label of the post.

How to test

  1. Click the compose textarea
  2. Use the Tab key several times to focus on the compose buttons and "created at" time.
  3. Confirm if the focus won't be lost so the application is navigable with the keyboard.

@stackblitz
Copy link

stackblitz bot commented Jul 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jul 22, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit ace8f7d
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/64bc07e72b4fd80008b29028
😎 Deploy Preview https://deploy-preview-2253--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 22, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit ace8f7d
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/64bc07e7ce3e9a0008abaa3f

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a big one. Thanks!

@patak-dev patak-dev merged commit b730fab into elk-zone:main Jul 22, 2023
16 checks passed
@shuuji3 shuuji3 deleted the fix/compose-menu-lost-focus branch July 23, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard accessibility/focus issues on desktop/desktop apps.
2 participants