feat: show delete confirmation dialog when clicking "Delete & re-draft" menu #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for elk-docs canceled.
|
|
Ah, it seems that the CI error is not related to this change. It started from this commit: e6172ad in the |
|
What's the default button focused when shown (if any)? We should focus the cancel button. Can you add Maybe the dialog component requires a review. |
antfu
approved these changes
Aug 2, 2023
|
@userquin Yeah I agree we should revise the design of the confirm dialog. It's not blocking this PR tho. |
|
Thank you both! I also agree on the above suggestions will improve the dialog UI. I'm going to try to make a separate PR to adjust the layout and add a title to the dialog later. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #2291
This change ensures to show the same dialog message as the "Delete" menu. I'm wondering if we'd better change the message but basically, both actions are warning about the same delete action so I assume the same message can be acceptable.