feat: add keyboard shortcut helper link or button #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shuuji3
force-pushed
the
feat/keyboard-shortcut-helper-link
branch
from
3aabe44
to
2a24e1d
Compare
userquin
approved these changes
Aug 25, 2023
|
Could we put it between |
|
Sure, that's also reasonable to place a more frequently used button on the sides. This button becomes used less frequently as the user becomes familiar with the shortcuts. |
antfu
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an explicit link/button to show the keyboard shortcut helper panel. I tried to implement both but that's just to evaluate which one is better (will revert one of the commits later).
I saw some people commented somewhere (sorry, couldn't find the original comment) that they didn't notice the keyboard shortcut is supported by Elk. This link/button can help to find the feature.