Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unocss): resolve match warning for uno #2386

Closed
wants to merge 2 commits into from

Conversation

zyyv
Copy link
Member

@zyyv zyyv commented Sep 8, 2023

Because of Uno extract the untransformed code to parse, made some warnings.
image

As a workaround, we can prepare the unitilities of generated in comment node.

@stackblitz
Copy link

stackblitz bot commented Sep 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit f679b9d
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/64fb0d87237b4900085e6a76

@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit f679b9d
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/64fb0d8713eb410008e2fb7d
😎 Deploy Preview https://deploy-preview-2386--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu
Copy link
Member

antfu commented Sep 8, 2023

I don't think this is a long-term solution. This adds extra mental burden as everytime we do so we need to remember to update the comment as well, which I don't it's a not ideal solution. I think we should improve the shortcut instead. I'll see what I can do

@antfu antfu closed this in 3691ec3 Sep 8, 2023
@edimitchel
Copy link
Collaborator

I was wondering some like that, isn't something UnoCSS should handle better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants