Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove redundant imports #2927

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

itoao
Copy link
Contributor

@itoao itoao commented Aug 23, 2024

Description

This PR removes redundant imports from several components to improve code cleanliness and maintainability.

Changes

  • Removed DurationPicker import from ModalConfirm.vue
  • Removed CommonScrollIntoView import from:
    • TiptapEmojiList.vue
    • TiptapHashtagList.vue
    • TiptapMentionList.vue

These imports are unnecessary due to Nuxt's Auto Import feature, which automatically imports components.

Motivation and Context

Keeping our codebase clean and free of unused imports helps improve:

  1. Code readability
  2. Maintainability

Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 4dc449a
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/66c8ad7a53b90f00099762d5

Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 4dc449a
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/66c8ad7a53b90f00099762d3
😎 Deploy Preview https://deploy-preview-2927--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patak-dev patak-dev added this pull request to the merge queue Aug 24, 2024
Merged via the queue into elk-zone:main with commit 53f3d44 Aug 24, 2024
13 checks passed
@itoao itoao deleted the refactor/remove-redundant-imports branch August 24, 2024 12:41
@shuuji3
Copy link
Member

shuuji3 commented Aug 24, 2024

Thank you, this is a good refactoring! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants