Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected redirect to upgrade after install #3225

Closed
emanuele45 opened this issue Jul 13, 2018 · 1 comment
Closed

Unexpected redirect to upgrade after install #3225

emanuele45 opened this issue Jul 13, 2018 · 1 comment
Milestone

Comments

@emanuele45
Copy link
Contributor

If the install directory is not deleted the just installed forum redirects to upgrade.
This is not technically wrong, because index.php finds the directory, and since there are correct data in Settings.php it thinks the install needs an upgrade.
Some more logic may be needed somewhere.

I would consider a "double redirect" to avoid too much logic in index.php:

  1. in index.php have only a redirect to the install directory,
  2. then move any more logic regarding what to do there (e.g. in an install/index.php)
@Vekseid
Copy link
Contributor

Vekseid commented Aug 3, 2018

Suggestion

  • Detect if upgrade file exists
  • If so, require version file in upgrade path.
  • If versions match, no redirect, warn admin.
  • If versions don't match, no redirect, link admin to upgrade.

tinoest added a commit to tinoest/Elkarte that referenced this issue Sep 16, 2018
@emanuele45 emanuele45 modified the milestones: 1.1.6, 1.1.7 Apr 7, 2019
Spuds added a commit to Spuds/Elkarte that referenced this issue Dec 15, 2020
Spuds added a commit to Spuds/Elkarte that referenced this issue Dec 17, 2020
Spuds added a commit that referenced this issue Dec 21, 2020
@Spuds Spuds closed this as completed Dec 21, 2020
Spuds added a commit to Spuds/Elkarte that referenced this issue Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants