Patches #1824
Merged
Patches #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1821
fix #1803
fix #1822
fix #1778 ??
Updated to use typeof ....
@emanuele45 The state check for footnotes / spoilers is a bit rough, what is there will not work in all places (like inside formatted text inside the bbc codes and other points ...
e.g. [footnote]bla1 bla2 bla3[/footnote] the cursor in bla2 will not trigger the state but in bla1 or dba2 will (although making that work has an side effect of active state with the cursor inside of the [footnote] tag itself in some instances.
TLDR its messy so this is just a goodie, worth it at all?