Move most directory read functions to SPL #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O_O |
|
Which part is confusing, or all of it, or just why 👅 |
|
LOL BTW, travis fails here as well, not I feel a little bit less sick. 🍭 ETA: is it just me or distinguish between "i" and "l" is a little difficult here at github? |
|
Yeah, not sure what is going on with the travis 5.4/mysqli/selenium run ...and debugging travis is a PITA! I'll setup some testbed and try and figure it out. |
emanuele45
added a commit
that referenced
this pull request
Apr 30, 2015
Move most directory read functions to SPL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from scandir, opendir, glob, readdir bla bla etc to SPL objects. Wrapped all in try/catch although the catch in most cases is a todo for maybe logging.