Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Rebroadcast and Validation Behaviour #195

Merged
merged 3 commits into from
Dec 24, 2018

Conversation

ncodes
Copy link
Member

@ncodes ncodes commented Dec 24, 2018

Commit Summary

Node

  • Prevented blocks from being broadcast to peers when a node is syncing.

Blockchain

  • Removed validation check that required a block's transactions to exist in the transaction pool.

Fixed Transaction Receipt Event Handling
…t in the transaction pool.

This rule was applied to blocks received when the client was not syncing with a peer.

However, it should be possible for a miner to add a transaction to a block without ever broadcasting it.

This fix makes it possible.
@ncodes ncodes merged commit 79a148c into dev Dec 24, 2018
@ncodes ncodes deleted the fixes/remove-txpool-check-during-block-processing branch December 24, 2018 20:32
@ncodes ncodes changed the title Block Rebroadcast and Validation Behaviours Block Rebroadcast and Validation Behaviour Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant