Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement memset memcpy memmove. Fixes #293 #692

Merged
merged 6 commits into from
Apr 30, 2018

Conversation

kamphaus
Copy link
Contributor

@kamphaus kamphaus commented Apr 27, 2018

Fixes #293


This change is Reviewable

@kamphaus kamphaus changed the title Implement memset memcpy. Fixes #293 Implement memset memcpy memmove. Fixes #293 Apr 27, 2018
@codecov
Copy link

codecov bot commented Apr 27, 2018

Codecov Report

Merging #692 into master will decrease coverage by 0.03%.
The diff coverage is 95.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
- Coverage   81.85%   81.82%   -0.04%     
==========================================
  Files         164      164              
  Lines        8875     8917      +42     
==========================================
+ Hits         7265     7296      +31     
- Misses       1208     1219      +11     
  Partials      402      402
Impacted Files Coverage Δ
program/function_definition.go 100% <ø> (ø) ⬆️
transpiler/unary.go 74.55% <100%> (ø) ⬆️
darwin/string.go 100% <100%> (ø) ⬆️
noarch/string.go 100% <100%> (ø) ⬆️
util/goast.go 88.2% <81.81%> (-4.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f403df...8256f55. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 4 of 5 files at r1, 1 of 2 files at r2.
Review status: 5 of 6 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@elliotchance
Copy link
Owner

Reviewed 1 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@elliotchance elliotchance merged commit e4188c6 into elliotchance:master Apr 30, 2018
@kamphaus kamphaus deleted the fix-293-memset-memcpy branch April 30, 2018 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants