Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement strstr, strcasestr. Fixes #713 #714

Merged
merged 1 commit into from
May 6, 2018

Conversation

corona10
Copy link
Contributor

@corona10 corona10 commented May 6, 2018

Fixes: #713


This change is Reviewable

@corona10 corona10 changed the title Implement strstr, strcasestr Fixes #713 Implement strstr, strcasestr. Fixes #713 May 6, 2018
@corona10 corona10 force-pushed the strstr branch 2 times, most recently from 373a2a7 to fbacfc8 Compare May 6, 2018 10:04
@codecov
Copy link

codecov bot commented May 6, 2018

Codecov Report

Merging #714 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #714      +/-   ##
==========================================
+ Coverage      82%   82.03%   +0.02%     
==========================================
  Files         164      164              
  Lines        9042     9056      +14     
==========================================
+ Hits         7415     7429      +14     
  Misses       1223     1223              
  Partials      404      404
Impacted Files Coverage Δ
program/function_definition.go 100% <ø> (ø) ⬆️
noarch/string.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fee818b...1785a8c. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


noarch/string.go, line 80 at r1 (raw file):

	}
	return str1[index : index+len(b)]
}

Nice! 👍


Comments from Reviewable

@elliotchance elliotchance merged commit 27de377 into elliotchance:master May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants