Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Struct field pointer arithmetics. Fixes #724 #725

Conversation

kamphaus
Copy link
Contributor

@kamphaus kamphaus commented May 8, 2018

Fixes #724


This change is Reviewable

This should already have the correct variable identifier and
also covers cases where LHS is a struct field.
@codecov
Copy link

codecov bot commented May 8, 2018

Codecov Report

Merging #725 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
- Coverage   81.71%   81.66%   -0.06%     
==========================================
  Files         165      165              
  Lines        9199     9195       -4     
==========================================
- Hits         7517     7509       -8     
- Misses       1271     1278       +7     
+ Partials      411      408       -3
Impacted Files Coverage Δ
transpiler/operators.go 78.64% <100%> (+0.2%) ⬆️
transpiler/call.go 66.8% <0%> (-2.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d3229...e9a283d. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit aaf7aa2 into elliotchance:master May 8, 2018
@kamphaus kamphaus deleted the fix-724-struct-field-pointer-arithmetics branch May 9, 2018 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants