Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malloc can create void* type. Fixes #726 #727

Merged
merged 2 commits into from
May 14, 2018

Conversation

kamphaus
Copy link
Contributor

@kamphaus kamphaus commented May 9, 2018

Fixes #726


This change is Reviewable

@codecov
Copy link

codecov bot commented May 9, 2018

Codecov Report

Merging #727 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
+ Coverage   81.63%   81.64%   +<.01%     
==========================================
  Files         165      165              
  Lines        9214     9218       +4     
==========================================
+ Hits         7522     7526       +4     
  Misses       1281     1281              
  Partials      411      411
Impacted Files Coverage Δ
transpiler/binary.go 71.48% <100%> (+0.23%) ⬆️
transpiler/variables.go 84.04% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b25b1...d33cac5. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit 1414a5c into elliotchance:master May 14, 2018
@kamphaus kamphaus deleted the fix-726-malloc-undefined branch May 14, 2018 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants