Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement strerror, errno. Fixes #728 #729

Merged
merged 8 commits into from
May 14, 2018

Conversation

kamphaus
Copy link
Contributor

@kamphaus kamphaus commented May 9, 2018

Fixes #728


This change is Reviewable

@codecov
Copy link

codecov bot commented May 9, 2018

Codecov Report

Merging #729 into master will decrease coverage by 0.14%.
The diff coverage is 45.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
- Coverage   81.63%   81.48%   -0.15%     
==========================================
  Files         165      166       +1     
  Lines        9214     9259      +45     
==========================================
+ Hits         7522     7545      +23     
- Misses       1281     1301      +20     
- Partials      411      413       +2
Impacted Files Coverage Δ
program/function_definition.go 100% <ø> (ø) ⬆️
noarch/util.go 70.21% <0%> (-18.98%) ⬇️
noarch/stdio.go 83.4% <36.36%> (-1.05%) ⬇️
noarch/errno.go 68% <68%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b25b1...9dfdcff. Read the comment docs.

@elliotchance
Copy link
Owner

Reviewed 2 of 5 files at r2, 3 of 3 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elliotchance elliotchance merged commit db6f68b into elliotchance:master May 14, 2018
@kamphaus kamphaus deleted the fix-728-strerror-errno branch May 14, 2018 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants