go generate generate.go used for first generate #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotchance
pushed a commit
that referenced
this pull request
Oct 6, 2021
Added DropWhile() function which is similar to `dropwhile()` function from `itertools` in Python. The `DropWhile()` function drops items from the slice while `f(item)` function returns `true`. Also used go generate in the README since go generate generate.go doesn't work from #173.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
go generate ./...is first used, thepiebinary might not have been installed on the user's system while trying to generate code for the internal types, since the command will not only create the pie templates but also try to generate code for the internal types. Which will generate an errorexecutable file not found in $PATHSo changing the first command to
go generate generate.gowill only create the pie templates and thengo installwill proceed to install the binary and the third and final commandgo generate ./...will use the newly created templatesto update the generated code
This change is