Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ClusterGetKeysInSlot command #6

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Add support for ClusterGetKeysInSlot command #6

merged 1 commit into from
Feb 11, 2019

Conversation

supernan1994
Copy link
Contributor

@supernan1994 supernan1994 commented Feb 11, 2019 •
edited
Loading

What I see:

./token_test.go:92:26: cannot use m (type *redismock.ClientMock) as type redis.Cmdable in field value:
	*redismock.ClientMock does not implement redis.Cmdable (missing ClusterGetKeysInSlot method)

What is changed:

Add support for latest version of go-redis.

This change is Reviewable

@supernan1994
Copy link
Contributor Author

@elliotchance PTAL

elliotchance
elliotchance approved these changes Feb 11, 2019
View reviewed changes
Copy link
Owner

@elliotchance elliotchance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@elliotchance elliotchance merged commit 1bed352 into elliotchance:master Feb 11, 2019
@elliotchance
Copy link
Owner

Thanks! 😄

@supernan1994
Copy link
Contributor Author

My pleasure😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliotchance elliotchance elliotchance approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@supernan1994 @elliotchance