Refactor dynamic finder away from class_eval with a string

simplify getting the class to define dynamic finders on
elliotcm · Mar 9, 2010 · 628e579 · 628e579
1 parent baf3733
commit 628e579
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1 +1,2 @@
-tmp
+.*.sw?
+tmp
diff --git a/lib/document/persistence.rb b/lib/document/persistence.rb
@@ -65,11 +65,11 @@ def index(key_name, options={})
 
           method_name = 'find_by_'+(options[:as] or key_name).to_s
           if viable_method_name(method_name)
-            (class << self; self; end).class_eval %{
-              def #{method_name}(value)
-                collection.find(:#{key_name} => value).map{|bson_hash| new(bson_hash)}
+            self.class.class_eval do
+              define_method method_name.to_sym do |value|
+                collection.find(key_name.to_sym => value).map{|bson_hash| new(bson_hash)}
               end
-            }
+            end
           end
 
           collection.create_index(key_name)