Add NinjaBuilder.outputDir
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a way for `@ninjutsu-build/*` packages to run from a different working directory from where the final `.ninja` file will be written to. This is because all plugins assume that their dependent scripts and executables reside in the `node_modules` folder in the current working directory. However, we (personally) would like to move our `configure.mjs` script to a `configure` folder to avoid a top-level `node_modules` directory and to keep the root directory clean. In order to support this the plugins will need to know to put the `configure` directory in the paths to scripts/executables found in the `configure/node_modules` directory. This change does not fix any plugins at the moment, only change the core `NinjaBuilder` component. The plugins will be fixed in future commits.
elliotgoodrich
force-pushed
the
add-ninjabuilder-outputDir
branch
from
072bf52
to
d8c9001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way for
@ninjutsu-build/*packages to run from a different working directory from where the final.ninjafile will be written to.This is because all plugins assume that their dependent scripts and executables reside in the
node_modulesfolder in the current working directory. However, we (personally) would like to move ourconfigure.mjsscript to aconfigurefolder to avoid a top-levelnode_modulesdirectory and to keep the root directory clean. In order to support this the plugins will need to know to put theconfiguredirectory in the paths to scripts/executables found in theconfigure/node_modulesdirectory.This change does not fix any plugins at the moment, only change the core
NinjaBuildercomponent. The plugins will be fixed in future commits.