Change the signature of plugin make* functions
#97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A while ago `@ninjutsu-build/core` was updated so that `NinjaBuilder.rule` could take any properties and these were taken as the default value for any build edges created with this rule. However, it was not possible to pass through arbitrary values for `implicitDeps` or `orderOnlyDeps` in the plugins, or to set defaults that we use ourselves (e.g. `configPath` for `@ninjutsu-build/biome`). All plugin exports take an optional object as the second parameter instead of an optional string for the rule name. This optional object can take the name, `implicitDeps`, `orderOnlyDeps`, and any rule-specific defaults that make sense. Right now this is just `configPath` for `@ninjutsu-build/biome`, but later on we can add more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago
@ninjutsu-build/corewas updated so thatNinjaBuilder.rulecould take any properties and these were taken as the default value for any build edges created with this rule.However, it was not possible to pass through arbitrary values for
implicitDepsororderOnlyDepsin the plugins, or to set defaults that we use ourselves (e.g.configPathfor@ninjutsu-build/biome).All plugin exports take an optional object as the second parameter instead of an optional string for the rule name. This optional object can take the name,
implicitDeps,orderOnlyDeps, and any rule-specific defaults that make sense. Right now this is justconfigPathfor@ninjutsu-build/biome, but later on we can add more.