Return None, instead of raising AttributeError on MarkupTextDescripto… #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r if no instance Django 1.11.2 get_or_create object is passing in None instance
|
Not sure how/why the changes I made caused travis-ci build to fail. |
|
@reinbach a new version of isort has been released a few days ago and it introduces new rules regarding import ordering. This is the reason why the build is failing. I'll provide a patch in master, so you'll be able to do a rebase in your branch. |
ellmetha
approved these changes
Jun 8, 2017
|
Thanks for the fix! 😉 |
ellmetha
pushed a commit
that referenced
this pull request
Jun 8, 2017
…r if no instance (#66) Django 1.11.2 get_or_create object is passing in None instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 1.11.2 get_or_create object is passing in None instance, resulting in the AttributeError exception being raised.
Seeing that a None is returned if field name not in the instance, I thought returning None for no instance would be ok. Tests pass and functionality does not appear to be impacted, so hopefully that is ok.
Tests don't pass for Django 1.11.2, but went ahead and created an explicit test for get_or_create_object.
Thank you for contributing to django-machina! A list of simple rules is available on the online
documentation to help you contribute to this project: https://django-machina.readthedocs.org/en/stable/contributing.html.
Please review these guidelines before submitting your pull request!