Move avatar rendering to a partial template #77
Conversation
| @@ -12,7 +12,7 @@ | |||
| <h3 class="panel-title">{% trans "Edit forum profile" %}</h3> | |||
| </div> | |||
| <div class="panel-body"> | |||
| <form method="post" action="." class="form" enctype="multipart/form-data" novalidate>{% csrf_token %} | |||
| <form method="post" action="." class="form" enctype="multipart/form-data" novalidate>{% csrf_token %}{% if AVATARS_ENABLED %} | |||
There was a problem hiding this comment.
I don't think this is the right way to disable the avatar field in the form. Technically a user could still upload an avatar since the Django form will still accept it. IMHO a better solution would be to manually remove the avatar form field in the FormProfileForm.__init__ method (here: https://github.com/ellmetha/django-machina/blob/master/machina/apps/forum_member/forms.py#L13) if the MACHINA_PROFILE_AVATARS_ENABLED setting is set to False. 😉
|
Sorry for the late reply, I was on vacation 😎. I made it so the field is completely removed from the form when avatars are disabled. |
|
@franga2000 I think we can leave the admin page as is. 😉 |
|
Thanks! |
A super easy, backwards-compatible way of allowing the use of external avatar apps.
Similar to what I proposed in #67, but implemented with a partial template rather than a tag.