Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the empty function never : Never -> a #1

Merged
merged 1 commit into from
May 17, 2016

Conversation

andersk
Copy link
Contributor

@andersk andersk commented May 15, 2016

This adds the missing destructor for the empty Never type. See elm-lang/core#593 for discussion.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@mgold
Copy link
Member

mgold commented May 15, 2016

Would this be caught and rejected once elm-lang/core#873 elm/compiler#873 is fixed?

@andersk
Copy link
Contributor Author

andersk commented May 15, 2016

@mgold Depends on the details. Of the possible definitions
never1 (Never n) = never1 n
never2 n = never2 n
never3 = never3
we would certainly want to accept never1 and reject the buggy never3, but one could imagine reasonable implementations that either accept or reject never2.

@jvoigtlaender
Copy link
Contributor

I would be very surprised if the Elm compiler would at some point reject the never2 definition.

@jvoigtlaender jvoigtlaender merged commit da432ef into elm-community:master May 17, 2016
@jvoigtlaender
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants