This repository has been archived by the owner on Oct 9, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This and the previous commit fix #115.
10 tasks
Awesome! Thanks @mgold :) |
Woo, awesome! 😻 |
rtfeldman
reviewed
Feb 26, 2017
describe "a describe with the same name as a child describe fails" | ||
[ describe "a describe with the same name as a child describe fails" | ||
[ test "a test" passingTest ] | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about sibling tests?
, expectToFail <|
Test.concat
[ describe "a describe with the same name as a sibling describe fails"
[ test "a test" passingTest ]
, describe "a describe with the same name as a sibling describe fails"
[ test "another test" passingTest ]
]
, expectToFail <|
Test.concat
[ Test.concat
[ describe "a describe with the same name as a de facto sibling describe fails"
[ test "a test" passingTest ]
]
, describe "a describe with the same name as a de facto sibling describe fails"
[ test "another test" passingTest ]
]
, expectToFail <|
Test.concat
[ Test.concat
[ describe "a describe with the same name as a de facto sibling describe fails"
[ test "a test" passingTest ]
]
, Test.concat
[ describe "a describe with the same name as a de facto sibling describe fails"
[ test "another test" passingTest ]
]
]
rtfeldman
suggested changes
Feb 26, 2017
, reason = Test.Expectation.Invalid Test.Expectation.DuplicatedName | ||
} | ||
else | ||
Internal.Labeled desc (Internal.Batch tests) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Test.concat
needs to run duplicatedName
too.
https://github.com/elm-community/elm-test/pull/133/files#r103121485 would fail if it's only on describe
!
@rtfeldman New commit adds your proposed tests and implementation to make them pass. |
Because tests is not needed in the closure, declare these functions once.
@rtfeldman What about now? |
rtfeldman
approved these changes
Mar 3, 2017
Love it! 😻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #115: automatically fail tests with duplicated names across parents/children and siblings. Test that this works. Rename a pair of tests in our suite that broke this rule.
👀 @rtfeldman @jfmengels