-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/elm.json still required for ALE to lint test files #64
Comments
I believe you can do |
@avh4 thanks for the suggestion! With elm 0.19.0 |
altaurog
added a commit
to altaurog/ale
that referenced
this issue
Jan 2, 2019
With earlier elm versions, a separate package file is maintained for tests, which when properly configured enabled the compiler to find what it needed to compile the tests. Under elm 0.19, test dependencies are managed in the top-level package file, so `elm make` will fail on the tests. `elm-test make` is required in this case. See elm-explorations/test#64
altaurog
added a commit
to altaurog/ale
that referenced
this issue
Jan 2, 2019
With earlier elm versions, a separate package file is maintained for tests, which when properly configured enabled the compiler to find what it needed to compile the tests. Under elm 0.19, test dependencies are managed in the top-level package file, so `elm make` will fail on the tests. `elm-test make` is required in this case. See elm-explorations/test#64
altaurog
added a commit
to altaurog/ale
that referenced
this issue
Jan 3, 2019
With earlier elm versions, a separate package file is maintained for tests, which when properly configured enabled the compiler to find what it needed to compile the tests. Under elm 0.19, test dependencies are managed in the top-level package file, so `elm make` will fail on the tests. `elm-test make` is required in this case. See elm-explorations/test#64
altaurog
added a commit
to altaurog/ale
that referenced
this issue
Jan 3, 2019
With earlier elm versions, a separate package file is maintained for tests, which when properly configured enabled the compiler to find what it needed to compile the tests. Under elm 0.19, test dependencies are managed in the top-level package file, so `elm make` will fail on the tests. `elm-test make` is required in this case. See elm-explorations/test#64
altaurog
added a commit
to altaurog/ale
that referenced
this issue
Jan 4, 2019
With earlier elm versions, a separate package file is maintained for tests, which when properly configured enabled the compiler to find what it needed to compile the tests. Under elm 0.19, test dependencies are managed in the top-level package file, so `elm make` will fail on the tests. `elm-test make` is required in this case. See elm-explorations/test#64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I gather that
test-dependencies
has been added toelm.json
(formerlyelm-package.json
) to separate test dependencies. This does indeed seem to be a better approach than maintainingtests/elm.json
separately.However, when using vim/ALE, I see import errors. ALE runs
elm make
under the hood. It looks to me like it is essentially:Which produces the following error
Of course, elm-explorations/test is in
test-dependencies
, notdependencies
.By creating
tests/elm.json
with adjustedsource-directories
anddependencies
, I can get the make command (and thereby ALE) to work. But this confuseselm-test
and it fails with the following:As a quick and dirty workaround, I have a bash function as follows:
But this is obviously not the right solution.
Is there a (better) way to do this now?
The text was updated successfully, but these errors were encountered: