Unicode string test failure output #47

drathier · 2018-10-31T13:26:12Z

This adds a unicode-escaped copy of any failing string that contains non-standard ascii characters.

I'm not completely happy with the formatting, so if you have suggestions, please do tell. Otherwise, I think it's still much better than what we currently have. I'm comparing the escaped strings, not character by character, which is why we're getting diffs that cover part of an escape sequence.

Solves elm-community/elm-test#225 and #38.

↓ Expectations
↓ Expect.equal on unicode strings should show pretty output
✗ ascii
           ▼        ▼▼       ▼▼  
    "\u{1f63b}\u{1f640}\u{1f47b}" (same string but with unicode characters escaped)
     ▼   
    "😻🙀👻"
    |> Expect.equal
    "🙀👻😻🙈"
       ▲▲ 
    "\u{1f640}\u{1f47b}\u{1f63b}\u{1f648}" (same string but with unicode characters escaped)
           ▲▲▲▲▲▲▲▲▲▲        ▲▲      ▲ ▲  


↓ Expectations
↓ Expect.equal on unicode strings should show pretty output
✗ ascii space vs nbsp
        ▼    
    "asd qwe"
    ╵
    │ |> Expect.equal
    ╷
    "asd qwe"
        ▲    
    "asd\u{00a0}qwe" (same string but with unicode characters escaped)
        ▲▲▲▲▲▲    


↓ Expectations
↓ Expect.equal on unicode strings should show pretty output
✗ ascii only
         ▼   
    "asd qwe"
    ╵
    │ |> Expect.equal
    ╷
    "asd dwe"
         ▲   


↓ Expectations
↓ Expect.equal on unicode strings should show pretty output
✗ newline diff
                   
    "first\nsecond"
    ╵
    │ |> Expect.equal
    ╷
    "first\r\nsecond"
           ▲▲        


↓ Expectations
↓ Expect.equal on unicode strings should show pretty output
✗ long lines
                                                                                                                                                                                                                                                                                                                                                                                                            ▼▼▼▼▼▼▼▼▼▼                                                                                                                                                                                                                                                                                                     
    "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Quisque in scelerisque arcu. Curabitur cursus efficitur turpis sed porttitor. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Nunc eu cursus ex. Proin accumsan quam quis dui semper finibus. Nunc vel nibh at tellus finibus rhoncus eu eget dolor. Sed eget neque ut lorem imperdiet fermentum. \u{1f63b} Morbi iaculis ante euismod, vulputate velit ut, varius velit. Nulla tempus dapibus mattis. In tempus, nisi a porta lobortis, nulla lacus iaculis quam, vel euismod magna risus at tortor. Integer porta urna odio. Nulla pellentesque dictum maximus. Donec auctor urna nec tortor imperdiet varius." (same string but with unicode characters escaped)
                                                                                                                                                                                                                                                                                                                                                                                                            ▼▼                                                                                                                                                                                                                                                                                                     
    "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Quisque in scelerisque arcu. Curabitur cursus efficitur turpis sed porttitor. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Nunc eu cursus ex. Proin accumsan quam quis dui semper finibus. Nunc vel nibh at tellus finibus rhoncus eu eget dolor. Sed eget neque ut lorem imperdiet fermentum. 😻 Morbi iaculis ante euismod, vulputate velit ut, varius velit. Nulla tempus dapibus mattis. In tempus, nisi a porta lobortis, nulla lacus iaculis quam, vel euismod magna risus at tortor. Integer porta urna odio. Nulla pellentesque dictum maximus. Donec auctor urna nec tortor imperdiet varius."
    ╵
    │ |> Expect.equal
    ╷
    "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Quisque in scelerisque arcu. Curabitur cursus efficitur turpis sed porttitor. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Nunc eu cursus ex. Proin accumsan quam quis dui semper finibus. Nunc vel nibh at tellus finibus rhoncus eu eget dolor. Sed eget neque ut lorem imperdiet fermentum. Morbi iaculis ante euismod, vulputate velit ut, varius velit. Nulla tempus dapibus mattis. In tempus, nisi a porta lobortis, nulla lacus iaculis quam, vel euismod magna risus at tortor. Integer porta urna odio. Nulla pellentesque dictum maximus. Donec auctor urna nec tortor imperdiet varius."

…copy of string if it has unicode characters in it.

drathier · 2018-10-31T13:28:36Z

We seem to have multiple copies of verticalBar etc., and this only updates the ones used in npm test. I'm wondering a bit why we have multiple copies of them?

harrysarson · 2018-10-31T13:46:17Z

How does it look if the strings are long or contain new lines?

drathier · 2018-10-31T14:58:51Z

Added a newline test (\n vs \r\n), those are typed out as their backslash escapes (this is how elm types them out in toString). Also added a very long line, hard to read test output in my terminal because of word wrap, but very easy without word wrap.

…ting.

mgold

Two small nits, otherwise looks good.

mgold · 2018-11-03T21:27:28Z

tests/src/Runner/String/Format.elm

+                                    "f"
+
+                                _ ->
+                                    String.fromInt (i |> remainderBy 16)


No need to call remainderBy again. decimalDigit -> String.fromInt decimalDigit

mgold · 2018-11-03T21:28:27Z

tests/src/Runner/String/Format.elm

+        |> List.map Char.toCode
+        |> List.map
+            (\c ->
+                if isAsciiChar c == False then


Use if not (isAsciiChar c) then or flip the conditional.

drathier · 2019-05-02T15:38:05Z

Better late than never, I guess.

mgold

Sure.

harrysarson · 2019-05-03T08:46:43Z

tests/src/Tests.elm

+        --         \_ -> "first\u{000a}second" |> Expect.equal "first\r\nsecond"
+        --     , test "long lines" <|
+        --         \_ -> "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Quisque in scelerisque arcu. Curabitur cursus efficitur turpis sed porttitor. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Nunc eu cursus ex. Proin accumsan quam quis dui semper finibus. Nunc vel nibh at tellus finibus rhoncus eu eget dolor. Sed eget neque ut lorem imperdiet fermentum. 😻 Morbi iaculis ante euismod, vulputate velit ut, varius velit. Nulla tempus dapibus mattis. In tempus, nisi a porta lobortis, nulla lacus iaculis quam, vel euismod magna risus at tortor. Integer porta urna odio. Nulla pellentesque dictum maximus. Donec auctor urna nec tortor imperdiet varius." |> Expect.equal "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Quisque in scelerisque arcu. Curabitur cursus efficitur turpis sed porttitor. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Nunc eu cursus ex. Proin accumsan quam quis dui semper finibus. Nunc vel nibh at tellus finibus rhoncus eu eget dolor. Sed eget neque ut lorem imperdiet fermentum. Morbi iaculis ante euismod, vulputate velit ut, varius velit. Nulla tempus dapibus mattis. In tempus, nisi a porta lobortis, nulla lacus iaculis quam, vel euismod magna risus at tortor. Integer porta urna odio. Nulla pellentesque dictum maximus. Donec auctor urna nec tortor imperdiet varius."
+        --     ]


Why are these tests commented out?

They're the tests used to show the output of failed string equality expectations. I don't know how to write meaningful automatic tests that check that the output remains the same.

harrysarson · 2019-05-03T08:47:37Z

tests/src/Runner/String/Format.elm

@@ -135,29 +203,64 @@ equalityToString : { operation : String, expected : String, actual : String } ->
 equalityToString { operation, expected, actual } =
    -- TODO make sure this looks reasonable for multiline strings


I think this pull request solves this TODO. 🙂

Unfortunately not :/ Long strings with automatic line wrapping still look weird.

Filip Haglund added 2 commits October 31, 2018 14:05

Change verticalBar to output a pipe character. Print unicode-escaped …

b670b63

…copy of string if it has unicode characters in it.

Pad up to 4 zeroes for unicode escapes.

2d7bdb5

drathier added the expectations Concerns assertions and comparisons label Oct 31, 2018

drathier self-assigned this Oct 31, 2018

drathier changed the title ~~Unicode string test failure output~~ WIP: Unicode string test failure output Oct 31, 2018

drathier requested review from rtfeldman and mgold October 31, 2018 13:28

Add one more commented out failing test for expectation output format…

6b5dd0c

…ting.

mgold requested changes Nov 3, 2018

View reviewed changes

Clean up code according to (very old) PR comments.

ae6194d

drathier changed the base branch from remove-expect-true-false to master May 2, 2019 15:37

drathier changed the title ~~WIP: Unicode string test failure output~~ Unicode string test failure output May 2, 2019

drathier requested a review from mgold May 2, 2019 15:38

mgold approved these changes May 3, 2019

View reviewed changes

drathier merged commit e8fe199 into master May 3, 2019

drathier deleted the unicode-string-test-failure-output branch May 3, 2019 08:46

harrysarson reviewed May 3, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unicode string test failure output #47

Unicode string test failure output #47

drathier commented Oct 31, 2018 •

edited

Loading

drathier commented Oct 31, 2018

harrysarson commented Oct 31, 2018

drathier commented Oct 31, 2018

mgold left a comment

mgold Nov 3, 2018

mgold Nov 3, 2018

drathier commented May 2, 2019

mgold left a comment

harrysarson May 3, 2019

drathier May 3, 2019

harrysarson May 3, 2019

drathier May 3, 2019

		@@ -135,29 +203,64 @@ equalityToString : { operation : String, expected : String, actual : String } ->
		equalityToString { operation, expected, actual } =
		-- TODO make sure this looks reasonable for multiline strings

Unicode string test failure output #47

Unicode string test failure output #47

Conversation

drathier commented Oct 31, 2018 • edited Loading

drathier commented Oct 31, 2018

harrysarson commented Oct 31, 2018

drathier commented Oct 31, 2018

mgold left a comment

Choose a reason for hiding this comment

mgold Nov 3, 2018

Choose a reason for hiding this comment

mgold Nov 3, 2018

Choose a reason for hiding this comment

drathier commented May 2, 2019

mgold left a comment

Choose a reason for hiding this comment

harrysarson May 3, 2019

Choose a reason for hiding this comment

drathier May 3, 2019

Choose a reason for hiding this comment

harrysarson May 3, 2019

Choose a reason for hiding this comment

drathier May 3, 2019

Choose a reason for hiding this comment

drathier commented Oct 31, 2018 •

edited

Loading