Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compile/v2 returning errors in JSON #2217

Merged
merged 7 commits into from
Aug 22, 2021
Merged

Add compile/v2 returning errors in JSON #2217

merged 7 commits into from
Aug 22, 2021

Conversation

terezka
Copy link
Contributor

@terezka terezka commented Aug 2, 2021

Quick Summary:

Endpoint /compile is unchanged. The new endpoint /compile/v2:

In case of successful compile: Returns resulting html for iframe, including a message out to notify editor of success.
In case of unsuccessful compile: Returns html for iframe which sends out the compilation problems (in JSON format) to editor.

This change was made in order to allow more advanced interactions with errors for the elm-lang.org/try page.

`/compile` still returns the old format.

`/compile/v2` returns the same for successful compiles, but returns compiling errors in a JSON format.
@terezka terezka requested a review from evancz August 2, 2021 15:58
@github-actions
Copy link

github-actions bot commented Aug 2, 2021

Thanks for suggesting these code changes. To set expectations:

  • Pull requests are reviewed in batches, so it can take some time to get a response.
  • Smaller pull requests are easier to review. To fix nine typos, nine specific issues will always go faster than one big one. Learn why here.
  • Reviewers may not know as much as you about certain situations, so add links to supporting evidence for important claims, especially regarding standards for CSS, HTTP, URI, etc.

Finally, please be patient with the core team. They are trying their best with limited resources.

@evancz evancz merged commit 3994905 into master Aug 22, 2021
@evancz evancz deleted the new-compile-endpoint branch August 22, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants